Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swmm roughness translation correction #214

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

tproduit
Copy link
Contributor

Add missing parenthesis after check with @TriformMoritz

@sjib
Copy link
Contributor

sjib commented Mar 24, 2023

@tproduit @TriformMoritz Thanks for checking and adaptions.

@sjib
Copy link
Contributor

sjib commented Mar 24, 2023

Has someone else the possibility to check this adapted view? @urskaufmann @DflGruBoe

@sjib
Copy link
Contributor

sjib commented May 19, 2023

@ponceta Should be merged to complete QGEP/qgepplugin#93

@sjib
Copy link
Contributor

sjib commented May 19, 2023

Should fix QGEP/QGEP#728

@cymed
Copy link
Contributor

cymed commented Oct 4, 2023

I checked: there are no overlapping changed lines with #220. The check against Versions 13 and 14 is pending.

sjib added a commit to teksi/wastewater that referenced this pull request Oct 5, 2023
@sjib sjib added the bug Due to something that is not working as expected label Oct 6, 2023
@ponceta ponceta closed this Oct 6, 2023
@ponceta ponceta reopened this Oct 6, 2023
@ponceta ponceta added this to the 1.6.1 milestone Nov 7, 2023
@ponceta ponceta added the Fix Fix a bug or something broken label Nov 7, 2023
@ponceta ponceta merged commit 164095e into QGEP:master Nov 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Due to something that is not working as expected Fix Fix a bug or something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants