Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSS rename xxx.fk_chute to xxx.fk_surface_water_bodies #215

Merged
merged 4 commits into from
Oct 9, 2023
Merged

DSS rename xxx.fk_chute to xxx.fk_surface_water_bodies #215

merged 4 commits into from
Oct 9, 2023

Conversation

sjib
Copy link
Contributor

@sjib sjib commented Mar 29, 2023 •
edited by ponceta
Loading

DSS rename xxx.fk_chute to xxx.fk_surface_water_bodies for :

  • qgep_od.water_catchment
  • qgep_od.sector_water_body
  • qgep_od.bathing_area

@sjib sjib marked this pull request as draft March 29, 2023 15:23
@sjib
Copy link
Contributor Author

sjib commented Mar 29, 2023 •
edited
Loading

  • to do: adapt also in 03_dss model

@sjib sjib mentioned this pull request Mar 29, 2023
Merged
@sjib sjib marked this pull request as ready for review March 29, 2023 15:44
@sjib sjib changed the title [WIP] delta_1.5.x_dss_rename_xxx_fk_chute_to_fk_surface_water_bodies.sql delta_1.5.x_dss_rename_xxx_fk_chute_to_fk_surface_water_bodies.sql Mar 29, 2023
@sjib sjib mentioned this pull request Apr 14, 2023
Closed
@sjib
Copy link
Contributor Author

sjib commented May 19, 2023

@ponceta Please assing delta 1.5.x number so it can be integrated in 2023.0 wastewater

@sjib sjib mentioned this pull request May 19, 2023
Open
7 tasks
@ponceta
Rename delta to 1.6.1
9c26936 
Rename delta to 1.6.1
@ponceta
Update version 1.6.1 to match after delta state
c60d2bd 
Update version 1.6.1  to match after delta state
@ponceta ponceta changed the title delta_1.5.x_dss_rename_xxx_fk_chute_to_fk_surface_water_bodies.sql delta_1.6.1_dss_rename_xxx_fk_chute_to_fk_surface_water_bodies.sql Jul 17, 2023
@ponceta ponceta changed the title delta_1.6.1_dss_rename_xxx_fk_chute_to_fk_surface_water_bodies.sql DSS rename_xxx_fk_chute_to_fk_surface_water_bodies.sql Oct 2, 2023
@sjib sjib mentioned this pull request Oct 4, 2023
Merged
@sjib sjib changed the title DSS rename_xxx_fk_chute_to_fk_surface_water_bodies.sql delta_1.6.1_dss_rename_xxx_fk_chute_to_fk_surface_water_bodies.sql Oct 6, 2023
@ponceta ponceta added this to the 1.6.1 milestone Oct 9, 2023
@ponceta ponceta changed the title delta_1.6.1_dss_rename_xxx_fk_chute_to_fk_surface_water_bodies.sql DSS rename xxx.fk_chute to xxx.fk_surface_water_bodies Oct 9, 2023
@ponceta ponceta self-assigned this Oct 9, 2023
@ponceta ponceta self-requested a review October 9, 2023 07:56
@ponceta ponceta assigned sjib and unassigned ponceta Oct 9, 2023
ponceta
ponceta approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@ponceta ponceta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated PR Comment, otherwise it looks good to me.

@ponceta ponceta closed this Oct 9, 2023
@ponceta ponceta reopened this Oct 9, 2023
@ponceta ponceta added feature New functionnality or behaviour improving/extending user experience Fix Fix a bug or something broken and removed feature New functionnality or behaviour improving/extending user experience labels Oct 9, 2023
@ponceta ponceta merged commit 2fec9ee into master Oct 9, 2023
4 checks passed
@ponceta ponceta deleted the delta_1.5.x_dss_rename_xxx_fk_chute_to_fk_surface_water_bodies branch October 9, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ponceta ponceta ponceta approved these changes

Assignees

@sjib sjib

Labels
Fix Fix a bug or something broken
Projects
None yet
Milestone
1.6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@sjib @ponceta