Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add additional structure part views #229

Merged
merged 1 commit into from
Nov 7, 2023
Merged

add additional structure part views #229

merged 1 commit into from
Nov 7, 2023

Conversation

cymed
Copy link
Contributor

@cymed cymed commented Oct 17, 2023

This PR adds the structure part views that are included in VSA DSS 2015 but not SIA 405

@cymed cymed requested a review from sjib October 17, 2023 12:37
sjib
sjib approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@sjib sjib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. With 2020 there will be one more: Spuelstutzen (flushing_nozzle)

@sjib sjib changed the title add structure part views add additional structure part views Oct 17, 2023
@ponceta ponceta added the feature New functionnality or behaviour improving/extending user experience label Nov 7, 2023
@ponceta ponceta added this to the 1.6.1 milestone Nov 7, 2023
@ponceta ponceta merged commit 3dfcecd into QGEP:master Nov 7, 2023
2 checks passed
@cymed cymed deleted the add_structure_part_views branch November 10, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjib sjib sjib approved these changes

Assignees

@cymed cymed

Labels
feature New functionnality or behaviour improving/extending user experience
Projects
None yet
Milestone
1.6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@cymed @sjib @ponceta