2024-10-11-fix-rollback_session

[sjib]

add missing function rollback_session

Should fix QGEP/QGEP#873

[sjib]

@ponceta Does this look like fixing the problem?

Could we eliminate the error messages in this block of commit_session?

        try:
            self.session.commit()
        except Exception as e:
            self.session.rollback_session()
            iface.messageBar().pushMessage("Error", f"An error occurred: {e}", level=Qgis.Warning)
            iface.messageBar().pushMessage("Error", "Import was canceled", level=Qgis.Warning)
        finally:
            self.session.close()

Or better keep them there and only do

    def rollback_session(self):
        self.session.rollback()

and not messages, as they are a kind of duplicates?

Thanks for reviewing

[ponceta]

This would be better reviewed by @domi4484 but IMHO it should be best to add rollback messages directly in the rollback function.

[ponceta]

I think you have to use the function you defined and not self.session.rollback_session()

    except Exception as e:
        self.rollback_session()
        iface.messageBar().pushMessage("Error", f"An error occurred: {e}", level=Qgis.Warning)
        iface.messageBar().pushMessage("Error", "Import was canceled", level=Qgis.Warning)

[sjib]

@ponceta better now?