Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

Ibmqprovider #307

Merged
merged 9 commits into from
Oct 7, 2018
Merged

Ibmqprovider #307

merged 9 commits into from
Oct 7, 2018

Conversation

jaygambetta
Copy link
Member

@jaygambetta jaygambetta commented Oct 7, 2018

Finishing getting started IBMQ provider This is part of issue #293

@jaygambetta
Copy link
Member Author

should be done but I will run it once more in the morning.

@jaygambetta jaygambetta mentioned this pull request Oct 7, 2018
4 tasks
Copy link
Contributor

@nonhermitian nonhermitian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not be using Qconfig files in this notebook. We do not need them, and are trying to kill them. We should just say token and, if in the IBM Q network, a url. If we want to highlight how to use the old Qconfig, then it should be done later in the notebook.

Also, you killed the job status because it took too long, and this is shown in the notebook. Why not use the Jupyter status monitor?

@jaygambetta
Copy link
Member Author

jaygambetta commented Oct 7, 2018

The qconfig here is not a old style qconfig it’s just a file that holds the url and token as I don’t want to display them. Read the flow and you see why.

@jaygambetta jaygambetta changed the title [ WIP] Ibmqprovider Ibmqprovider Oct 7, 2018
ajavadia
ajavadia previously approved these changes Oct 7, 2018
Copy link
Member

@ajavadia ajavadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is well done.

@jaygambetta
Copy link
Member Author

Thanks @ajavadia next is visualizations

@jaygambetta
Copy link
Member Author

@ajavadia your fix broke.

@jaygambetta jaygambetta dismissed ajavadia’s stale review October 7, 2018 15:46

until its fixed from your changes

@jaygambetta
Copy link
Member Author

thanks @ajavadia it works. Please approve again and @nonhermitian have a look.

@jaygambetta jaygambetta merged commit 19ce1fc into Qiskit:master Oct 7, 2018
@jaygambetta jaygambetta deleted the ibmqprovider branch October 23, 2018 01:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants