Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to reno from release #11942

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Conversation

mtreinish
Copy link
Member

Summary

We had previously been using reno from a git to get early access to the subsections feature and also a bugfix with excessive debug logging (thanks to @Eric-Arellano for implementing both of these). However, with the recent release of reno 4.1.0 these have been included in a release and we no longer need to rely on a pre-release of reno. This commit updates reno version listed in requirements-dev.txt to be >=4.1.0.

Details and comments

We had previously been using reno from a git to get early access to the
subsections feature and also a bugfix with excessive debug logging
(thanks to @Eric-Arellano for implementing both of these). However, with
the recent release of reno 4.1.0 these have been included in a release
and we no longer need to rely on a pre-release of reno. This commit
updates reno version listed in requirements-dev.txt to be >=4.1.0.
@mtreinish mtreinish added type: qa Issues and PRs that relate to testing and code quality Changelog: None Do not include in changelog labels Mar 4, 2024
@mtreinish mtreinish requested a review from a team as a code owner March 4, 2024 14:15
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@Eric-Arellano
Copy link
Collaborator

also a bugfix with excessive debug logging

Possibly my highest impact contribution to Qiskit 😅 semi /s

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8141651964

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.03%) to 89.303%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 93.81%
crates/qasm2/src/lex.rs 4 91.18%
Totals Coverage Status
Change from base Build 8117135103: 0.03%
Covered Lines: 59126
Relevant Lines: 66208

💛 - Coveralls

Copy link
Contributor

@kevinhartman kevinhartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kevinhartman kevinhartman added this pull request to the merge queue Mar 4, 2024
Merged via the queue into Qiskit:main with commit 85411bb Mar 4, 2024
12 checks passed
IsmaelCesar pushed a commit to comp-quantica/qiskit-terra that referenced this pull request Mar 13, 2024
We had previously been using reno from a git to get early access to the
subsections feature and also a bugfix with excessive debug logging
(thanks to @Eric-Arellano for implementing both of these). However, with
the recent release of reno 4.1.0 these have been included in a release
and we no longer need to rely on a pre-release of reno. This commit
updates reno version listed in requirements-dev.txt to be >=4.1.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants