Avoid Python op creation in BasisTranslator

[mtreinish]

Summary

This commit updates the BasisTranslator transpiler pass. It builds off
of #12692 and #12701 to adjust access patterns in the python transpiler
path to avoid eagerly creating a Python space operation object. The goal
of this PR is to mitigate the performance regression introduced by the
extra conversion cost of #12459 on the BasisTranslator.

Details and comments

TODO:

• Fix 2 failing test cases with control flow
• Benchmark and profile
• Rebase after Enable avoiding Python operation creation in transpiler #12692 and Avoid Python op creation in commutative cancellation #12701 merge

This PR is built on top of #12692 and #12701 and will need to rebased after both merge. To view the contents of just this PR you can look at the last commit on the branch (I'll be force pushing updates to that last commit): d95ef61

[coveralls]

Pull Request Test Coverage Report for Build 9783354867

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 30 of 30 (100.0%) changed or added relevant lines in 2 files are covered.
• 11 unchanged lines in 3 files lost coverage.
• Overall coverage increased (+0.01%) to 89.838%

---

Files with Coverage Reduction	New Missed Lines	%
qiskit/transpiler/passes/basis/basis_translator.py	1	97.7%
crates/qasm2/src/lex.rs	4	92.88%
crates/qasm2/src/parse.rs	6	97.61%

Totals
Change from base Build 9782487328:	0.01%
Covered Lines:	65136
Relevant Lines:	72504

---

💛 - Coveralls

[jakelishman]

Note: this will conflict with #12730.

[qiskit-bot]

One or more of the following people are relevant to this code:

• @Qiskit/terra-core
• @kevinhartman
• @mtreinish

[mtreinish]

I'm marking this as ready to review. From profiling there is still significant overhead in substitute_node_with_dag() that gets called a lot by the basis translator. While I could work on mitigating that I think between #12730 and then eventually #12550 will just take care of that. So if we need to do something for 1.2 there we can handle it in a follow up.

[jakelishman]

I'm fine to merge this now, and I'll fix up the merge conflict in #12730. I think that #12730 will already fix very nearly all the remaining overhead in substitute_node_with_dag (all the stuff about "additional wires") around node.op creation, and the last change (an isinstance(node.op, ControlFlowOp)) is trivial.

[coveralls]

Pull Request Test Coverage Report for Build 9874529504

Details

• 30 of 30 (100.0%) changed or added relevant lines in 2 files are covered.
• 12 unchanged lines in 3 files lost coverage.
• Overall coverage decreased (-0.007%) to 89.887%

---

Files with Coverage Reduction	New Missed Lines	%
qiskit/transpiler/passes/basis/basis_translator.py	1	97.7%
crates/qasm2/src/lex.rs	5	93.13%
crates/qasm2/src/parse.rs	6	97.61%

Totals
Change from base Build 9871528102:	-0.007%
Covered Lines:	65741
Relevant Lines:	73137

---

💛 - Coveralls