Parsing of seed_transpiler in generate_preset_pass_manager
#12980
Conversation
qiskit-bot
added
the
Community PR
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
|
|
Pull Request Test Coverage Report for Build 10466743768Details
💛 - Coveralls |
qiskit/transpiler/preset_passmanagers/generate_preset_pass_manager.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I added a minor suggestion for the release note wording to indicate the fix a bit clearer, other than than LGTM. This PR reminds me that we could probably refactor the tests using generate_preset_pass_manager to be a bit easier to find/contribute to.
PS: you can directly click on "commit suggestion" just below the suggested snippets and this will automatically commit the suggested changes ("add suggestion to batch" allows you to group several suggestions in a single commit).
Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
qiskit/transpiler/preset_passmanagers/generate_preset_pass_manager.py
Outdated
Show resolved
Hide resolved
…ager.py Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
ElePT
added
the
stable backport potential
* Raise ValueError if seed_transpiler is negative * Fix code formatting * Implement suggested changes * Update releasenotes/notes/fix-negative-seed-pm-2813a62a020da115.yaml Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com> * Update qiskit/transpiler/preset_passmanagers/generate_preset_pass_manager.py Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com> --------- Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com> (cherry picked from commit 5c8edd4)
…ort #12980) (#12996) * Parsing of `seed_transpiler` in `generate_preset_pass_manager` (#12980) * Raise ValueError if seed_transpiler is negative * Fix code formatting * Implement suggested changes * Update releasenotes/notes/fix-negative-seed-pm-2813a62a020da115.yaml Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com> * Update qiskit/transpiler/preset_passmanagers/generate_preset_pass_manager.py Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com> --------- Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com> (cherry picked from commit 5c8edd4) * Update test/python/transpiler/test_preset_passmanagers.py * Update test/python/transpiler/test_preset_passmanagers.py --------- Co-authored-by: jschuhmac <74537145+jschuhmac@users.noreply.github.com> Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
Summary
Parsing of
seed_transpilerargument ofgenerate_preset_pass_managerraises aValueErrorif negative value is provided for the seed.Details and comments
Fixes #12938.
Parsing function for
seed_transpileradded to parsing other non-target dependent pass manager options.The added test checks that
ValueErroris indeed raised if seed takes negative value.