Re-allow non-standard includes in OpenQASM 3 exporter #13148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swapping the behaviour of the exporter to error on unknown includes was a mistake, and a breaking change from previous versions of the OpenQASM 3 exporter, since the `basis_gates` argument can be used to emulate the expected behaviour of this option, even though the previously documented behaviour was never actually fulfilled. This restores the previous non-erroring behaviour, and corrects the documentation to note how the ``includes`` argument should be used in the near term.
jakelishman
added
stable backport potential
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 10847859520Details
💛 - Coveralls |
mergify bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
Swapping the behaviour of the exporter to error on unknown includes was a mistake, and a breaking change from previous versions of the OpenQASM 3 exporter, since the `basis_gates` argument can be used to emulate the expected behaviour of this option, even though the previously documented behaviour was never actually fulfilled. This restores the previous non-erroring behaviour, and corrects the documentation to note how the ``includes`` argument should be used in the near term. (cherry picked from commit 5121a0f)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
Swapping the behaviour of the exporter to error on unknown includes was a mistake, and a breaking change from previous versions of the OpenQASM 3 exporter, since the `basis_gates` argument can be used to emulate the expected behaviour of this option, even though the previously documented behaviour was never actually fulfilled. This restores the previous non-erroring behaviour, and corrects the documentation to note how the ``includes`` argument should be used in the near term. (cherry picked from commit 5121a0f) Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Swapping the behaviour of the exporter to error on unknown includes was a mistake, and a breaking change from previous versions of the OpenQASM 3 exporter, since the
basis_gatesargument can be used to emulate the expected behaviour of this option, even though the previously documented behaviour was never actually fulfilled.This restores the previous non-erroring behaviour, and corrects the documentation to note how the
includesargument should be used in the near term.Details and comments
Fix #13061