Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix in ElidePermutations (backport #13186) #13191

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 19, 2024

Summary

A bug fix for the ElidePermutations pass where the internal qubit mapping was not updated correctly after a PermutationGate. This fix was already present in #13094, however we have decided to separate it to an independent PR as to allow backport.


This is an automatic backport of pull request #13186 done by [Mergify](https://mergify.com).

* elide permutations fix

* extending the test to check the final permutation

(cherry picked from commit adf55e1)
@mergify mergify bot requested a review from a team as a code owner September 19, 2024 17:40
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@github-actions github-actions bot added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Sep 19, 2024
@github-actions github-actions bot added this to the 1.2.2 milestone Sep 19, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10946135521

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 89.778%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 2 92.98%
Totals Coverage Status
Change from base Build 10938909061: 0.02%
Covered Lines: 66888
Relevant Lines: 74504

💛 - Coveralls

@jakelishman jakelishman added this pull request to the merge queue Sep 19, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 19, 2024
* elide permutations fix

* extending the test to check the final permutation

(cherry picked from commit adf55e1)

Co-authored-by: Alexander Ivrii <alexi@il.ibm.com>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 19, 2024
@jakelishman jakelishman added this pull request to the merge queue Sep 19, 2024
Merged via the queue into stable/1.2 with commit ed53512 Sep 19, 2024
18 checks passed
@mtreinish mtreinish deleted the mergify/bp/stable/1.2/pr-13186 branch September 20, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants