Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metatest for swap mappers #1571
Metatest for swap mappers #1571
Changes from 84 commits
c6cd32e
86efad4
ed98c8f
c75d27e
05d7419
96caf94
82d951b
4d437a8
37d6120
4e0576c
91cf8ab
e3893aa
b5a39f0
38d1081
1c4512e
2741d1b
e7188fc
ef34713
b82bac4
2239d0d
8e57c99
59ad155
97755b7
4c9c798
4386fd0
b28c806
6ea64e6
0f1f154
311773a
f49b824
0f14aa5
89e1938
7aee530
afe73e9
62cac69
24135e2
f4af4d5
5052302
ef6b599
b97d850
e322df6
7a06db7
e37c033
e3f408b
8543327
535155f
1d3f6cd
a56d141
a4b697e
8ae54eb
75da141
a87550d
337af76
a39d082
2daf8ff
569dda4
ed734bc
cab76e1
ce59e5f
52e1b6d
76bea9a
4d44872
26535a6
a69acdd
962363a
9087f12
bc5cdbb
5dca49d
d2eb393
ce1b3a2
69c6fc2
0b82ad0
6c7223c
d89b599
41386b2
7068919
d94ce61
2263a5a
eae9672
bffbe53
c6ca567
0d65f25
248267b
fa408a5
47860da
9bb634a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the
create_backend
andcreate_passmanager
methods are just one line each, why not just inline them?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because they are lines that need to be repeated in every test. I prefer to keep the test as clean as possible and encapsulate the complications that are not relevant to the result. Additionally, if we change the backend, this allows to change it in a single place.