Make Optimize1qGatesSimpleCommuation and Optimize1qGatesDecomposition passes Target aware

[TheGupta2012]

Summary

Make Optimize1qGatesSimpleCommuation (O1QC) and Optimize1qGatesDecomposition (O1QD) passes Target aware, in continuation of #7113

Details and comments

• This PR tries to make the above passes target aware by introducing target as a parameter

Optimize1qGatesSimpleCommuation

• O1QC did not have any direct dependence to the target (as far as I could figure out) but depended indirectly through O1QD

Optimize1qGatesDecomposition

• In O1QD, three major changes were introduced -
  • In the constructor, decomposers were checked for the target.operation_names instead of the basis_set. This is beacuse if target was provided, then decomposition was required for the operations supported by it.
  • In _substitution_checks, gates were checked for whether they were supported by target or not as target support should supersede the basis_set
  • In run method, again check for the optimization of u3 gate was changed. It included check for whether the qubit on which u3 was being performed, whether it was supported by target or not. If it was, then relevant optimization was done including some additional checks for u1 and u2 gates.

Note

• The test for the changes hasn't been added yet as I wasn't exactly sure if this was the correct way to do the target introduction. Would love to know if this was somewhat correct or not!

[qiskit-bot]

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

• @Qiskit/terra-core

[coveralls]

Pull Request Test Coverage Report for Build 2232867480

• 31 of 44 (70.45%) changed or added relevant lines in 3 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.01%) to 84.315%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
qiskit/transpiler/passes/optimization/optimize_1q_commutation.py	5	6	83.33%
qiskit/transpiler/passes/optimization/optimize_1q_decomposition.py	25	37	67.57%

Totals
Change from base Build 2231814429:	-0.01%
Covered Lines:	54538
Relevant Lines:	64684

---

💛 - Coveralls

[mtreinish]

Thanks for opening this, I apologize that it sat for so long without review. I know we talked about this PR offline together and discussed some changes to be made but I never circled back to check on the status, which is my bad. In the meantime another PR implementing the same thing was recently opened in #8917 and I think is taking a better approach for making these passes target aware, including factoring in the error rates as the selection heuristic. So I'm going to close this PR as I feel it's been superseded by #8917 now. But, please feel free to re-open this if you disagree or I'm missing something and we can continue to discuss it.