Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PauliOp.adjoint() #9434

Merged
merged 4 commits into from
Jan 24, 2023
Merged

Conversation

king-p3nguin
Copy link
Contributor

Summary

Details and comments

@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Jan 23, 2023
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@coveralls
Copy link

coveralls commented Jan 23, 2023

Pull Request Test Coverage Report for Build 3996187682

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.925%

Totals Coverage Status
Change from base Build 3986989992: 0.0%
Covered Lines: 66707
Relevant Lines: 78548

💛 - Coveralls

@woodsp-ibm woodsp-ibm added Changelog: Bugfix Include in the "Fixed" section of the changelog mod: opflow Related to the Opflow module labels Jan 23, 2023
Copy link
Contributor

@Cryoris Cryoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment on the reno otherwise LGTM 👍🏻

@Cryoris Cryoris added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Jan 24, 2023
Co-authored-by: Julien Gacon <gaconju@gmail.com>
Copy link
Contributor

@Cryoris Cryoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@mergify mergify bot merged commit 85c30a2 into Qiskit:main Jan 24, 2023
mergify bot pushed a commit that referenced this pull request Jan 24, 2023
* bug fix

* reno mod

* reno mod

* Update releasenotes/notes/fix-PauliOp-adjoint-a275876185df989f.yaml

Co-authored-by: Julien Gacon <gaconju@gmail.com>

Co-authored-by: Julien Gacon <gaconju@gmail.com>
(cherry picked from commit 85c30a2)
mergify bot added a commit that referenced this pull request Jan 24, 2023
* bug fix

* reno mod

* reno mod

* Update releasenotes/notes/fix-PauliOp-adjoint-a275876185df989f.yaml

Co-authored-by: Julien Gacon <gaconju@gmail.com>

Co-authored-by: Julien Gacon <gaconju@gmail.com>
(cherry picked from commit 85c30a2)

Co-authored-by: Kazuki Tsuoka <kazukitsuoka@g.ecc.u-tokyo.ac.jp>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@king-p3nguin king-p3nguin deleted the pr-fix-PauliOp-adjoint branch January 25, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo mod: opflow Related to the Opflow module stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

PauliOp.adjoint() does not return correct value
5 participants