Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 0.23.0 release #9438

Merged
merged 24 commits into from
Jan 26, 2023
Merged

Prepare 0.23.0 release #9438

merged 24 commits into from
Jan 26, 2023

Conversation

mtreinish
Copy link
Member

@mtreinish mtreinish commented Jan 23, 2023

Summary

This commit prepares the 0.23.0 release, this involves 2 steps first changing all the version numbers to 0.23.0 from 0.23.0rc1 and secondly updating the release notes to prepare them for publishing.

One key thing to note is that this PR removes the 0.22.0 release notes. This is because for the 0.22.0rc1 tag we neglected to move the release notes to a separate directory. So when we did that for the 0.22.0 final release we had to forward port this back to main so that any backports to stable/0.22 would be backportable (see #8901). However, this causes reno to detect all the 0.22 release notes are incorrectly as part of the 0.23.0 development series. To fix this the simplest path forward was to remove the 0.22.0 release notes from the 0.23.0 branch (as in this PR).

Details and comments

TODO

  • Remove backported release notes
  • Review and edit all 0.23.0 release notes

This commit prepares the 0.23.0 release, this involves 2 steps first
changing all the version numbers to 0.23.0 from 0.23.0rc1 and secondly
updating the release notes to prepare them for publishing.

One key thing to note is that this PR removes the 0.22.0 release notes.
This is because for the 0.22.0rc1 tag we neglected to move the release
notes to a separate directory. So when we did that for the 0.22.0 final
release we had to forward port this back to main so that any backports
to stable/0.22 would be backportable (see Qiskit#8901). However, this causes
reno to detect all the 0.22 release notes are incorrectly as part of the
0.23.0 development series. To fix this the simplest path forward was to
remove the 0.22.0 release notes from the 0.23.0 branch (as in this PR).
@mtreinish mtreinish added the Changelog: None Do not include in changelog label Jan 23, 2023
@mtreinish mtreinish added this to the 0.23.0 milestone Jan 23, 2023
@mtreinish mtreinish requested a review from a team as a code owner January 23, 2023 20:14
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

Copy link
Contributor

@Cryoris Cryoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on the releasenotes 🙂

mtreinish and others added 6 commits January 24, 2023 10:49
Co-authored-by: Julien Gacon <gaconju@gmail.com>
One release note to call out is the release note for Qiskit#8568 has been
changed significantly. This is based on Qiskit#9445 which is reverting some
breaking changes made as part of Qiskit#8568.
@mtreinish mtreinish changed the title [WIP] Prepare 0.23.0 release Prepare 0.23.0 release Jan 25, 2023
@mtreinish
Copy link
Member Author

I've finished my first pass going over the release notes, so this PR should be ready to review now.

Copy link
Contributor

@kevinhartman kevinhartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a review of prepare-0.23.0-release...yaml.

kdk
kdk previously approved these changes Jan 26, 2023
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly typos, there's like 3 actual comments.

Comment on lines +10 to +20
being ignored. If you need to assign a ``label`` to an
instance of :class:`~.MCMT` or :class:`~.MCMTVChain` you should convert
them to an :class:`~.Gate` instance with :meth:`~.QuantumCircuit.to_gate`
and then assign the desired label to :attr:`~.Gate.label` attribute. For
example::

from qiskit.circuit.library import MCMT, XGate

mcmt_circuit = MCMT(XGate(), 3, 2)
mcmt_gate = mcmt_circuit.to_gate()
mcmt_gate.label = "Custom MCMT X"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically you're right to include this, but in practice, label is something we're going to want to heavily de-emphasise in the move to singletons. This gate probably won't end up as a singleton, but even so, we maybe want to drop this bit?

Suggested change
being ignored. If you need to assign a ``label`` to an
instance of :class:`~.MCMT` or :class:`~.MCMTVChain` you should convert
them to an :class:`~.Gate` instance with :meth:`~.QuantumCircuit.to_gate`
and then assign the desired label to :attr:`~.Gate.label` attribute. For
example::
from qiskit.circuit.library import MCMT, XGate
mcmt_circuit = MCMT(XGate(), 3, 2)
mcmt_gate = mcmt_circuit.to_gate()
mcmt_gate.label = "Custom MCMT X"
being ignored.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example wasn''t in there originally and I was struggling to visualize exactly what a user doing MCMT(..., label="") was meant to do with just the text which is why I added the example. I don't really feel strongly one way or the other though, I think this is a definitely and edge use case. But I just generally feel upgrade notes should state the alternative if one is available (or the justification why one isn't).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to leave this on the basis of providing complete release notes tbh.

Co-authored-by: Jake Lishman <jake@binhbar.com>
@mergify mergify bot merged commit 5d6ba50 into Qiskit:stable/0.23 Jan 26, 2023
@mtreinish mtreinish deleted the prep-0230 branch January 26, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants