Fix SolovayKitaev for roundoff errors in Qiskit gates
#9441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Shelly Garion <46566946+ShellyGarion@users.noreply.github.com>
Cryoris
added
stable backport potential
Cryoris
requested review from
a team,
alexanderivrii and
ShellyGarion
as code owners
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
mtreinish
reviewed
Jan 24, 2023
ShellyGarion
approved these changes
Jan 24, 2023
There was a problem hiding this comment.
I can confirm that I do not see the bug again in my Linux environment.
I checked both the circuit in the test and the original circuit in #9437
Pull Request Test Coverage Report for Build 3998021160
💛 - Coveralls |
mtreinish
approved these changes
Jan 24, 2023
|
@Mergifyio refresh |
✅ Pull request refreshed |
mergify bot
pushed a commit
that referenced
this pull request
Jan 24, 2023
* fix tol and skip test for Qiskit gates * Add regression test Co-authored-by: Shelly Garion <46566946+ShellyGarion@users.noreply.github.com> * add reno * flip the check_input! * properly include ``check_input`` in all ``_recurse`` * rm reno -- SK not released yet Co-authored-by: Shelly Garion <46566946+ShellyGarion@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 088a84f)
mtreinish
removed
the
Changelog: Bugfix
mergify bot
added a commit
that referenced
this pull request
Jan 24, 2023
* fix tol and skip test for Qiskit gates * Add regression test Co-authored-by: Shelly Garion <46566946+ShellyGarion@users.noreply.github.com> * add reno * flip the check_input! * properly include ``check_input`` in all ``_recurse`` * rm reno -- SK not released yet Co-authored-by: Shelly Garion <46566946+ShellyGarion@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 088a84f) Co-authored-by: Julien Gacon <gaconju@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9437.