-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements new indicator IBS - Internal Bar Strength #8151
Merged
Martin-Molinero
merged 17 commits into
QuantConnect:master
from
femtotrader:feature-8124-new_indic_InternalBarStrenght
Jul 11, 2024
Merged
Implements new indicator IBS - Internal Bar Strength #8151
Martin-Molinero
merged 17 commits into
QuantConnect:master
from
femtotrader:feature-8124-new_indic_InternalBarStrenght
Jul 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martin-Molinero
requested changes
Jul 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you,
Leaving some minor requests, needs a rebase from master too sorry 👍
Martin-Molinero
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement new indicator - IBS
Related Issue
Closes #8124
Motivation and Context
The InternalBarStrenght indicator is a measure of the relative position of a period's closing price to the same period's high and low.
Requires Documentation Change
Doc for this indicator should be created but some docstring are written
How Has This Been Tested?
comparison with talipp computation of IBS() of SPY candle data using generate_reference_data_from_talipp.py
Types of changes
Checklist:
bug-<issue#>-<description>
orfeature-<issue#>-<description>