-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements new indicator ForceIndex #8155
Implements new indicator ForceIndex #8155
Conversation
I have no idea why |
Thanks, @femtotrader! For all the new PRs, can you please attach the source code of the comparison with Tulip, which generates the test data? We want to make sure all indicators have a third-party benchmark. |
Indicators are tested against talipp (Python) not tulipindicators (which is a great technical indicator lib also... but in C) Source code of the comparison with talipp have ever been merged in this PR I don't have an other (second) comparison script for tulipindicators . |
Tulip indicators have a Python binding https://github.com/TulipCharts/tulipy which is marked as [NOT ACTIVELY MAINTAINED] ... so I don't know what to think about it. This fork https://github.com/jesse-ai/tulipy (which have been used by Jesse bot) doesn't seems to be in a better state. If comparison should be done against tulip indicators also we probably should rely on a C/C++ program for that purpose (which is an other story) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looks good, sharing minor requests 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @femtotrader! Almost there 👍 minor comment
Description
Implement new indicator - ForceIndex
Related Issue
Closes #8123
Motivation and Context
The ForceIndex indicator wasn't implemented
Requires Documentation Change
Doc for this indicator should be created but some docstring are written
How Has This Been Tested?
comparison with talipp computation of ForceIndex(20) of SPY candle data using generate_reference_data_from_talipp.py
Types of changes
Checklist:
bug-<issue#>-<description>
orfeature-<issue#>-<description>