-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use jemalloc for aligned allocation #165
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as long as the CI tests pass. One comment, but I don't think it's necessary to do anything if you don't want to.
Looks like the build is failing with
during the installation of glmnet_python. That doesn't seem related to any of the changes you made. But I'm pretty sure we pinned to a specific glmnet_python commit so I'm confused why you're getting that error. |
The CI failure could be related to conda-forge/ctng-compilers-feedstock#23 |
Just want to point out that this doesn't work for me right now. |
They were just temporarily added to fix the CI. You don't need them on OSX. |
Next jemalloc packaging issue: conda-forge/jemalloc-feedstock#19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks Uwe!
* Use jemalloc for aligned allocation * Use sized deallocation
* Use jemalloc for aligned allocation * Use sized deallocation
This also fixes the OSX build (cc @MarcAntoineSchmidtQC ) and should also improve on allocation times).
Depends on conda-forge/jemalloc-feedstock#18