Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename to quantcore.glm #185

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Rename to quantcore.glm #185

merged 1 commit into from
Jun 5, 2020

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Jun 5, 2020

No description provided.

tbenthompson
tbenthompson approved these changes Jun 5, 2020
View reviewed changes
Copy link
Collaborator

@tbenthompson tbenthompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scanned through and the CI passes, so I'd say this is good to go. But, get Liz's thoughts before merging!

ElizabethSantorellaQC
ElizabethSantorellaQC approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@ElizabethSantorellaQC ElizabethSantorellaQC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@xhochy xhochy merged commit f5bdf1d into master Jun 5, 2020
@xhochy xhochy deleted the quantcore.glm branch June 5, 2020 14:44
tbenthompson pushed a commit that referenced this pull request Oct 8, 2021
@xhochy
Merge pull request #185 from Quantco/quantcore.glm
c0981fc 
Rename to quantcore.glm
tbenthompson pushed a commit that referenced this pull request Oct 8, 2021
@xhochy
Merge pull request #185 from Quantco/quantcore.glm
babf4a4 
Rename to quantcore.glm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbenthompson tbenthompson tbenthompson approved these changes

@ElizabethSantorellaQC ElizabethSantorellaQC ElizabethSantorellaQC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xhochy @tbenthompson @ElizabethSantorellaQC