Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add daily unit tests #502

Merged
merged 29 commits into from
Jan 3, 2022
Merged

Add daily unit tests #502

merged 29 commits into from
Jan 3, 2022

Conversation

BenBarrettQC
Copy link
Contributor

@BenBarrettQC BenBarrettQC commented Dec 28, 2021

Closes #429.

I've set this up for Linux so far (pending your feedback I will add macOS and Windows) and issues are opened on CI failure (see e.g. #499).

Some additional comments:

  • Some tests against the nightly builds of pandas, numpy and scikit-learn are currently running into errors due to this, which gets imported upstream here.
  • Other tests against the nightly builds are failing here because the option context is finding duplicate keys; I suspect we just need to add e.g. "display." to max_rows etc.
  • The other daily tests are currently passing (i.e. non-nightly tests), see e.g. here.
  • Once you're happy with the PR I'll comment in the code section that opens issues on CI failure; I wanted to avoid spamming everyone for now.
  • Test against tabmat nightlies #498 to follow.

Checklist

  • Added a CHANGELOG.rst entry

@BenBarrettQC
Copy link
Contributor Author

Minor update:

  1. I've now bundled Test against tabmat nightlies #498 into this PR.
  2. Based on preliminary discussions with @jtilly it seems only running tests against nightly builds on Linux might be sufficient for now.

.github/actions/daily_unittests/action.yml Outdated Show resolved Hide resolved
.github/workflows/test_daily.sh Outdated Show resolved Hide resolved
.github/workflows/test_daily.sh Outdated Show resolved Hide resolved
.github/workflows/daily.yml Outdated Show resolved Hide resolved
.github/workflows/daily.yml Show resolved Hide resolved
.github/workflows/test_daily.sh Outdated Show resolved Hide resolved
.github/actions/daily_unittests/action.yml Show resolved Hide resolved
.github/workflows/daily.yml Outdated Show resolved Hide resolved
.github/workflows/daily.yml Outdated Show resolved Hide resolved
@jtilly
Copy link
Member

jtilly commented Jan 3, 2022

Cool, thanks! Almost ready to merge.

  • Can you please open a separate issue in glum for the dask_ml.preprocessing.DummyEncoder problem and then don't test against the scikit-learn nightlies until that's fixed?
  • Can you fix the display max_rows issue? (You can do this as part of this PR.)
  • Can you remove the commented out code from the other workflows?

@jtilly jtilly merged commit fd38196 into main Jan 3, 2022
@jtilly jtilly deleted the issue-429a branch January 3, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Periodic unit tests
2 participants