Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major CI cleanup #674

Merged
merged 32 commits into from
Aug 15, 2023
Merged

Major CI cleanup #674

merged 32 commits into from
Aug 15, 2023

Conversation

pavelzw
Copy link
Member

@pavelzw pavelzw commented Aug 13, 2023

No description provided.

@pavelzw pavelzw changed the title Use micromamba in CI Use micromamba in CI + cleanup Aug 13, 2023
@pavelzw
Copy link
Member Author

pavelzw commented Aug 13, 2023

The current state of this PR runs the CI on every PR commit for all systems. If we want to limit this depending on if it is a PR or if it is push: main, we can also generate the matrix dynamically, similar to https://github.com/pavelzw/homebrew-pavelzw/blob/daa7f792956b4a0d36e1f5220ba3ee08adaa0294/.github/workflows/bump.yml#L13-L40

@pavelzw pavelzw changed the title Use micromamba in CI + cleanup Major CI cleanup Aug 13, 2023
@pavelzw pavelzw marked this pull request as ready for review August 13, 2023 17:51
Copy link
Member

@MarcAntoineSchmidtQC MarcAntoineSchmidtQC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks a lot for the cleanup.
Regarding whether we want to run builds on all architecture for every branch/PR, I think the original reason was that MacOS and Windows runners are much more expensive and we don't need it as much. Let's try it with your approach and reevaluate later whether we want to restrict them again.

My main comment is about the frequency at which we run the conda-build CI. I think right now it would basically only run when we merge a PR (if this PR doesn't modify the CI files). I think we should run it more often.

.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/conda-build.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@pavelzw
Copy link
Member Author

pavelzw commented Aug 14, 2023

I think the original reason was that MacOS and Windows runners are much more expensive

I might be wrong here but are we even paying for the CI resources in this repo since it is open-source? @xhochy

@pavelzw pavelzw merged commit ffc289a into main Aug 15, 2023
25 checks passed
@pavelzw pavelzw deleted the pavelzw-ci-micromamba branch August 15, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants