Update mirror for nightlies #718
Conversation
jtilly
requested review from
MarcAntoineSchmidtQC,
xhochy and
lbittarello
as code owners
|
With the last commit we are now able to build the environment. The tests are failing because the new channel points to numpy 2.0. From what I can see, there's a simple fix (switch from |
|
|
||
| PRE_WHEELS="https://pypi.anaconda.org/scipy-wheels-nightly/simple" | ||
| PRE_WHEELS="https://pypi.anaconda.org/scientific-python-nightly-wheels/simple/" |
There was a problem hiding this comment.
Adding a review comment so that we do not merge this right now. We need to fix the errors caused by the newer versions.
|
Reading a bit on numpy 2.0. I'm worried that the switch to scientific-python-nightly-wheels will be problematic. The fact that it's more up to date also has a downside: the probability that those packages are not yet working together is much higher. Currently, Pandas does not work with numpy 2.0: pandas-dev/pandas#55519. |
|
Yep, got it. But that just means we shouldn't test against NumPy 2.0. I think it doesn't justify using an outdated mirror that won't get updated any longer 😉 |
|
I didn't know that the scipy-wheels-nightly was deprecated. I just thought that it was using older versions. So you are totally right, we should absolutely be switching. I checked and pandas fixed the problem the same day we discussed it. I think our failures were mostly due to bad timing, so I'm willing to make the switch. I made a PR to fix this. The nightly build is passing with numpy 2.0! #720 |
scientific-python-nightly-wheels is a lot more up to date than scipy-wheels-nightly.
CI failure is because of #714.