Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct syntax for peer deps #24

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Conversation

noahflk
Copy link
Contributor

@noahflk noahflk commented Aug 17, 2022

Without this I wasn't able to install the library in an npm project. pnpm seems to be fine with the syntax either way.

The error I had before this fix

npm ERR! Found: next@12.2.4
npm ERR! node_modules/next
npm ERR!   next@"12.2.4" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer next@"12.x | 11.x" from next-international@0.1.1
npm ERR! node_modules/next-international
npm ERR!   next-international@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Copy link
Owner

@QuiiBz QuiiBz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I don't use NPM anymore so I wasn't aware of this issue. LGTM

@QuiiBz QuiiBz merged commit a7e7674 into QuiiBz:main Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants