Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/semtech-loramac: don't force ztimer rtt backend #16566

Merged

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Jun 17, 2021

Contribution description

This PR removes the hard dependency of ztimer RTT backend used by semtech-loramac package. AFAIU, with #16553, the RTT backend is only used when the periph_rtt is provided by the board.

Testing procedure

  • Green Murdock
  • Semtech-loramac package based applications are still functional
  • Check that ztimer RTT backend is used with b-l072z-lrwan1 board (which is the default for semtech-loramac applications)
  • Check that examples/lorawan and tests/pkg_semtech-loramac can be built with im880b (no RTT provided so cannot be used in current master)

Issues/PRs references

Follow-up of #16553

@aabadie aabadie added the Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation label Jun 17, 2021
@aabadie aabadie requested a review from fjmolinas June 17, 2021 11:10
@aabadie aabadie requested a review from jia200x as a code owner June 17, 2021 11:10
@github-actions github-actions bot added Area: LoRa Area: LoRa radio support Area: pkg Area: External package ports labels Jun 17, 2021
@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 17, 2021
@jia200x
Copy link
Member

jia200x commented Jun 17, 2021

Check that ztimer RTT backend is used with b-l072z-lrwan1 board (which is the default for semtech-loramac applications)

BOARD=b-l072z-lrwan1 make info-modules | grep ztimer_periph_rtt 
ztimer_periph_rtt

@jia200x
Copy link
Member

jia200x commented Jun 17, 2021

Check that examples/lorawan and tests/pkg_semtech-loramac can be built with im880b (no RTT provided so cannot be used in current master)

RIOT/examples/lorawan/ BOARD=im880b make > /dev/null && echo "OK"              
OK

RIOT/tests/pkg_semtech-loramac/ BOARD=im880b make > /dev/null && echo "OK"
OK

@jia200x
Copy link
Member

jia200x commented Jun 17, 2021

Tested on nucleo-l452re:

2021-06-17 14:40:35,526 # Connect to serial port /dev/ttyACM0
Welcome to pyterm!
Type '/exit' to exit.
loramac set deveui ...
2021-06-17 14:42:30,028 # loramac set deveui ...
> loramac set appeui ...
2021-06-17 14:42:39,155 # loramac set appeui ...
> loramac set appkey ...
2021-06-17 14:42:47,962 # loramac set appkey ...
> loramac join otaa
2021-06-17 14:42:51,158 # loramac join otaa
2021-06-17 14:43:00,525 # Join procedure succeeded!
> loramac tx test
2021-06-17 14:43:12,351 # loramac tx test
2021-06-17 14:43:15,824 # Received ACK from network
2021-06-17 14:43:15,826 # Message sent with success

Copy link
Member

@jia200x jia200x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Jun 17, 2021
@aabadie aabadie merged commit 1011af2 into RIOT-OS:master Jun 17, 2021
@aabadie aabadie deleted the pr/pkg/semtech-loramac-no-force-periph_rtt branch June 17, 2021 16:09
@MrKevinWeiss MrKevinWeiss added this to the Release 2021.07 milestone Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: LoRa Area: LoRa radio support Area: pkg Area: External package ports Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants