Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brush up p4b functions and export them #59

Merged
merged 3 commits into from
May 24, 2024
Merged

brush up p4b functions and export them #59

merged 3 commits into from
May 24, 2024

Conversation

jacobvjk
Copy link
Member

@jacobvjk jacobvjk commented May 24, 2024

relates to ADO tickets: 10829:10834

  • updates format_p4b() and format_p4b_ei() for better legibility
  • updates documentation of format_p4b() and format_p4b_ei() and exports them for use in other repos
  • updates dictionary_p4i_p4b() to include recent scenario publications
  • gains basic tests

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.79%. Comparing base (449448d) to head (4537f81).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   12.17%   16.79%   +4.61%     
==========================================
  Files          13       13              
  Lines        2028     2048      +20     
==========================================
+ Hits          247      344      +97     
+ Misses       1781     1704      -77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobvjk jacobvjk marked this pull request as ready for review May 24, 2024 11:38
@jacobvjk jacobvjk merged commit 59379db into main May 24, 2024
13 checks passed
@jacobvjk jacobvjk deleted the update-format_p4b branch May 24, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants