remove chrome install no longer needed for pacta.data.scraping

[cjyetman]

closes #91

[cjyetman]

This seems to work on my machine. Can either @jdhoffa and/or @AlexAxthelm verify that one their machines?

[jdhoffa]

Can you point me to input files that I can test this with?

[cjyetman]

Can you point me to input files that I can test this with?

It should work with any valid input files. The input files are largely irrelevant to this change because this change should only affect the ability to run pacta.data.scraping::get_index_regions().

[jdhoffa]

I have no input datasets on my computer ("valid" or otherwise), and am unsure where such data lives now, so I am unable to review this in its entirety.

If you think that, for this particular PR, stepping through the run_pacta_data_preparation.R until the point of pacta.data.scraping::get_index_regions() is sufficient, then I can do that.

But in general, I would prefer not merging PRs to PROD repos without sufficiently testing their stability (in the absence of any kind of real automated CI/CD)

(NIT: A big nudge towards us making pacta.demo.data :) )

[cjyetman]

If you think that, for this particular PR, stepping through the run_pacta_data_preparation.R until the point of pacta.data.scraping::get_index_regions() is sufficient, then I can do that.

Unfortunately not, because this PR does not affect the running-in-RStudio method of running data.prep at all, it only impacts whether running in the specified Docker image/container will have the necessary system dependencies.

But in general, I would prefer not merging PRs to PROD repos without sufficiently testing their stability (in the absence of any kind of real automated CI/CD)

💯 that's why I'm hoping one or both of you can verify it too

[cjyetman]

Though, if one of you has a way to step through the process in the Docker container to only test that pacta.data.scraping::get_index_regions() still works and you're confident/satisfied with that, I guess that would be enough.

[jdhoffa]

Docker run triggered, I will let you know what happens at the scraping step

[jdhoffa]

Success: