Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dense models and GNINA default model #44

Merged
merged 7 commits into from
Jul 29, 2022
Merged

Add support for dense models and GNINA default model #44

merged 7 commits into from
Jul 29, 2022

Conversation

RMeli
Copy link
Owner

@RMeli RMeli commented Jul 29, 2022

Description

Thanks to @drewnutt #43 , the correct weights for the dense models are now available, which allow to support the dense models alongside default2017 and default2018. More importantly, this allows to build the default model ensemble, thus reproducing all results obtained with GNINA.

PR Checklist

  • Tests
  • Documentation

@RMeli RMeli self-assigned this Jul 29, 2022
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #44 (57c82a5) into main (1b768a9) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@RMeli
Copy link
Owner Author

RMeli commented Jul 29, 2022

In the GNINA 1.0 paper there is a small typo: the default ensemble uses the redock_default2018_2 model, instead of the redock_default2018 model (as written in the paper).

GNINA 1.0 implementation, for reference:

https://github.com/gnina/gnina/blob/aab122edf91b59c07de48a0922256f34a809c49b/gninasrc/lib/cnn_scorer.cpp#L102-L109

@RMeli RMeli merged commit fc181fb into main Jul 29, 2022
@RMeli RMeli deleted the dense branch July 29, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant