-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rerank test #1778
Comments
thanks for a great hackathon everyone, I think we have achieved the goal! There is a new example script here: Its current output is this:
Note that at the very moment only the /beta endpoint has the required modifications to make this work. Will be replicated to other endpoints soon. The next and more bold maneuver would be to test with someone else's result! |
Awesome! |
Yes, that muffled boom you heard was me trying it on someone else's result set, one from BTE. It failed. Here's the error from the logs:
|
@chunyuma do you think this might be because those queries are not there when we generate COHD? Maybe we could add some error catching where we just skip that edge if a curie is not present in the |
Hi @edeutsch and @finnagin, this bug is because those queries have no return from the COHD API (https://cohd.io/api/translator/biolink_to_omop). I've fixed this bug by skipping these edges. It should work now. |
Awesome, thanks! |
Yes, thank you! I have just rolled out the latest master to all endpoints that follow master. Rerunning the example script now succeeds as follows:
The resultset as furnished originally by BTE is this: https://arax.ncats.io/?r=843990fb-4cd0-46c0-95cb-644990b226e5 The little test program fetches this results, strips out all scores (not really necessary, but perhaps feels like a closer example) and then runs it through /beta with the workflow we devised and the result is: https://arax.ncats.io/beta/?r=36024
Anyway, it works at a basic level, but maybe it could work a bit better. |
I think maybe the lack of ngd is because we use the fastngd method which is per-computed from our curies. |
@edeutsch Is this issue still relevant? |
I think we got it working well enough at the last hackathon, closing. |
No description provided.
The text was updated successfully, but these errors were encountered: