Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure database file naming follows the names mentioned in config_dbs.json #1949

Closed
sundareswarpullela opened this issue Jan 12, 2023 · 3 comments
Assignees

Comments

@sundareswarpullela
Copy link
Collaborator

Right now, the database files are not following the naming convention mentioned in the config_dbs.json, file.
The following file changes are being done manually ones the files are saved:
kg2c.sqlite --> kg2c_v1.0_KG2.8.0.sqlite
fda_approved_drugs.pickle --> fda_approved_drugs_v1.0_KG2.8.0c.pickle
kg2c_meta_kg.json --> meta_kg_v1.0_KG2.8.0c.json
autocomplete.sqlite --> autocomplete_v1.0_KG2.8.0.sqlite

@sundareswarpullela sundareswarpullela self-assigned this Jan 12, 2023
sundareswarpullela added a commit that referenced this issue Jan 13, 2023
sundareswarpullela added a commit that referenced this issue Jan 20, 2023
@sundareswarpullela
Copy link
Collaborator Author

This has been tested on a test build with the versioning implementation through kg2c_config.json.

@amykglen
Copy link
Member

amykglen commented Feb 2, 2023

awesome, thanks! should we close this issue since it's done and tested?

@sundareswarpullela
Copy link
Collaborator Author

Yes this is tested. This can be closed. Apologies for the delay

@amykglen amykglen closed this as completed Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants