-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenTelemetry (OTel) logging in ARAX #2186
Comments
I've reached out to Yaphet to better understand the requirements, and I have learned the following:
Unclear to which Jaeger service we can log, from services running on |
Still discussing with Yaphet how to get a Jaeger server (addressable on the Internet) spun up that we can use in development work. |
Latest info from Yaphet is:
|
@kvnthomas98 This is something that NCATS wants quite soon. Is this something you can work on, pausing your other MVP2 work? |
Thank you @dkoslicki |
Sure @dkoslicki I will look it into this. |
Hi @saramsey , Do you have the ITRB jaeger endpoints for each maturity level? |
We don't yet have access to an already-running (as in, provided for us by the SRI team) Jaeger endpoint that is on the Internet (though I understand that Yaphet is researching how to set that up). However, within an ITRB-deployed container, I am told that the following OpenTelemetry configuration should work, and the hostname should resolve:
I have not tested that, however. And it seems (to me) not ideal if our only way to test it out, is to deploy to ITRB CI. |
Note that they are working on some documentation here: It would likely be useful to read that and provide feedback/comments. It is an open PR. |
@kvnthomas98 I think the documentation that @edeutsch linked is helpful; it explains how to run a local Jaeger, which we can use in development and testing. I was hoping that SRI would provide us with an Internet-addressable Jaeger endpoint that we could use in testing, but apparently there are some issues with that (so it is still pending). In the meantime, I think maybe we should try moving forward with using a "local Jaeger" for development and testing on arax.ncats.io. See this section of the documentation that Eric linked: |
@kvnthomas98 what kind of EC2 instance would you need for hosting a Jaeger collector? Can you describe the hardware requirements? And storage requirements? Also what version of Ubuntu? I think we typically use Ubuntu 22.04? |
Hi all, from the Translator Release Schedule Timeline Google sheet, it's looking like we have two weeks to code this issue and get it into CI; I think the opportunity to push these updates to TEST will be on Dec. 15. |
Oof, Kevin is currently working on an ordering and organizing ask that also has the same deadline. |
Looks like the previous commit was to the |
Hi @saramsey, Once you've brought up the instance, please do let me know. I can work on setting up docker, jaeger collector and elastic search and testing our ARAX code. |
Hi @kvnthomas98 I have created an
I've installed docker (from
You can run Jaeger locally via the command (which is adapted from the one in the installation instructions on the Jaeger website):
I've put that command in a shell-script and I can make a TCP connection from
and to port 4318 as well:
Just to minimize cost, I've opted to stop the instance until we are ready to test it. So whenever you want to test out OpenTelemetry, simply do the following three steps:
|
The following simple demonstration python code snippet, run in python3.9 inside the
The above python code (which was adapted from a demo program from the ARAGORN team) requires the following packages to be installed:
Note, not all of the imported packages are used in the code snippet; so the code and the required packages could be simplified somewhat, and also will likely change for us in any event because we use python-requests instead of httpx. But, it illustrates that the opentelemetry SDK is working for sending spans (or messages or whatever they are called) to our Jaeger collector on
And the view from the Jaeger frontend: |
wow, that's really adding a lot of... complexity |
Thank you @kvnthomas98 for putting together this PR. |
#2186 Open Telemetry Implementation using Jaeger Exporter
code pushed to ITRB-Test! closing! |
Hi all,
The latest three-month development milestones for Translator are calling for all ARAs and KPs to implement OpenTelemetry logging of web API calls, by end of December. We will need to do this for ARAX and (I suppose, insofar as it does call PloverDB via a web API) RTX-KG2.
The text was updated successfully, but these errors were encountered: