Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we add medicament to our block list? #2224

Closed
edeutsch opened this issue Dec 5, 2023 · 4 comments
Closed

Can we add medicament to our block list? #2224

edeutsch opened this issue Dec 5, 2023 · 4 comments
Assignees
@kvnthomas98

Comments

@edeutsch
Copy link
Collaborator

edeutsch commented Dec 5, 2023

What is our procedure for adding generic things to our block list?

Sarah is pointing out a answer of 'medicament' from ARAX:

NCATSTranslator/Feedback#655

can we adjust ARAX to drop that?
@edeutsch
Copy link
Collaborator Author

@kvnthomas98 would you add medicament to our block list for ARAX?

kvnthomas98 added a commit that referenced this issue Dec 22, 2023
@kvnthomas98
Adding medicament to block list #2224
afd6f32
kvnthomas98 added a commit that referenced this issue Dec 22, 2023
@kvnthomas98
#2224
c2333e2
@kvnthomas98
Copy link
Collaborator

We can add more items to the blocklist by adding items to the json file here you can add them to the synonyms list where we can use regular expressions to remove nodes matching the particular pattern mentioned or we can add identifiers under the curies key

saramsey added a commit that referenced this issue Jan 3, 2024
@saramsey
#2224
960f0d3
saramsey added a commit that referenced this issue Jan 3, 2024
@saramsey
oops, reverting #2224 since @kvnthomas98 already fixed in a branch
776b1f3
@saramsey saramsey removed their assignment Jan 3, 2024
@saramsey
Copy link
Member

saramsey commented Jan 3, 2024

Thanks for fixing this, @kvnthomas98

@dkoslicki
Copy link
Member

Are we good to close on this one?

@dkoslicki dkoslicki mentioned this issue Apr 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kvnthomas98 kvnthomas98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@saramsey @dkoslicki @edeutsch @kvnthomas98