Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated librosa to version 0.10.2 #2159

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tkyaji
Copy link

@tkyaji tkyaji commented Jun 26, 2024

Pull request checklist

  • The PR has a proper title. Use Semantic Commit Messages. (No more branch-name title please)

  • Make sure this is ready to be merged into the relevant branch. Please don't create a PR and let it hang for a few days.

  • Ensure you can run the codes you submitted succesfully. These submissions will be prioritized for review:

    Introduce improvements in program execution speed;

    Introduce improvements in synthesis quality;

    Fix existing bugs reported by user feedback (or you met);

    Introduce more convenient user operations.

PR type

  • Bug fix

Description

There is a bug in librosa 0.9.1.
librosa/librosa#1594

As a result, an error occurs when executing the "Vocals/Accompaniment Separation & Reverberation Removal" function.

Error log

xxx.mp3.reformatted.wav->Traceback (most recent call last):
  File "/workspace/Retrieval-based-Voice-Conversion-WebUI/infer/modules/uvr5/modules.py", line 74, in uvr
    pre_fun._path_audio_(
  File "/workspace/Retrieval-based-Voice-Conversion-WebUI/infer/modules/uvr5/vr.py", line 119, in _path_audio_
    wav_instrument = spec_utils.cmb_spectrogram_to_wave(
  File "/workspace/Retrieval-based-Voice-Conversion-WebUI/infer/lib/uvr5_pack/lib_v5/spec_utils.py", line 397, in cmb_spectrogram_to_wave
    spectrogram_to_wave(
  File "/workspace/Retrieval-based-Voice-Conversion-WebUI/infer/lib/uvr5_pack/lib_v5/spec_utils.py", line 295, in spectrogram_to_wave
    wave_left = librosa.istft(spec_left, hop_length=hop_length)
  File "/workspace/Retrieval-based-Voice-Conversion-WebUI/venv/lib/python3.10/site-packages/librosa/util/decorators.py", line 88, in inner_f
    return f(*args, **kwargs)
  File "/workspace/Retrieval-based-Voice-Conversion-WebUI/venv/lib/python3.10/site-packages/librosa/core/spectrum.py", line 394, in istft
    dtype = util.dtype_c2r(stft_matrix.dtype)
  File "/workspace/Retrieval-based-Voice-Conversion-WebUI/venv/lib/python3.10/site-packages/librosa/util/decorators.py", line 88, in inner_f
    return f(*args, **kwargs)
  File "/workspace/Retrieval-based-Voice-Conversion-WebUI/venv/lib/python3.10/site-packages/librosa/util/utils.py", line 2185, in dtype_c2r
    np.dtype(complex): np.dtype(np.float).type,
  File "/workspace/Retrieval-based-Voice-Conversion-WebUI/venv/lib/python3.10/site-packages/numpy/__init__.py", line 324, in __getattr__
    raise AttributeError(__former_attrs__[attr])
AttributeError: module 'numpy' has no attribute 'float'.
`np.float` was a deprecated alias for the builtin `float`. To avoid this error in existing code, use `float` by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use `np.float64` here.
The aliases was originally deprecated in NumPy 1.20; for more details and guidance see the original release note at:
    https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations. Did you mean: 'cfloat'?

To address this issue, librosa has been upgraded to version 0.10.2.
Additionally, torchcrepe has been upgraded due to its dependency on librosa.

There is a bug in librosa 0.9.1.
librosa/librosa#1594

As a result, an error occurs when executing the "Vocals/Accompaniment Separation & Reverberation Removal" function.

To address this issue, librosa has been upgraded to version 0.10.2.
Additionally, torchcrepe has been upgraded due to its dependency on librosa.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant