Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #62: Dashboard doesn't show ESSID with special characters #63

Closed
wants to merge 23 commits into from
Closed

Conversation

marrold
Copy link

@marrold marrold commented Mar 24, 2017

Fix for #62 Dashboard doesn't show ESSID with special characters

@jrmhaig
Copy link
Collaborator

jrmhaig commented Mar 24, 2017

A problem with this is that the ESSID is then displayed verbatim on this line:

https://github.com/marrold/raspap-webgui/blob/bc97b36743204b1466f372ed9de524ef97992e7a/includes/dashboard.php#L99

so if, for example, your ssid is one<b>two</b>three it would be displayed with "two" in bold. Potentially this could be used to do something more malicious such as injecting javascript. Can you please change the line shown above to use the htmlspecialchars function to correctly escape the special characters. Thanks.

@billz
Copy link
Member

billz commented May 19, 2017

The original issue related to the ESSID #49 is resolved. The other changes remove a lot of key functionality, such as responsive nav for mobile devices, auth, CSRF tokens, system panel, etc. It seems this is quite a different project so I'll hold off merging this branch, thanks.

@billz billz closed this May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants