rbindlist works for expression column #3811
Conversation
inst/tests/tests.Rraw
Outdated
| # expression columns in rbindlist #546 | ||
| a <- data.table(c1 = 1, c2 = 'asd', c3 = expression(as.character(Sys.time()))) | ||
| b <- data.table(c1 = 3, c2 = 'qwe', c3 = expression(as.character(Sys.time()+5))) | ||
| test(2098, rbind(a,b)$c3, expression(as.character(Sys.time()), as.character(Sys.time()+5))) |
There was a problem hiding this comment.
I don't find this useful at all. The new expression doesn't even evaluate. I am against combining language objects in rbindlist. The useful scenario I had in the past was to have them in a list column, which at that time I was not aware (5 years ago).
Codecov Report
@@ Coverage Diff @@
## master #3811 +/- ##
==========================================
+ Coverage 99.41% 99.41% +<.01%
==========================================
Files 72 71 -1
Lines 13909 13266 -643
==========================================
- Hits 13828 13189 -639
+ Misses 81 77 -4
Continue to review full report at Codecov.
|
|
maybe just add unit tests modifying original example by wrapping expressions into lists? then PR will cover some existing use case. |
|
Marked as 1.13.0 as a way to exclude from 1.12.4, but still come back to it. |
|
codecov results aren't updating. log states that upload succeeded but then there's a timeout after that line. a rerun didn't fix it. proceeding to merge and we should see master's coverage update. |
Closes #546
Seems we shouldn't go too far down the path of allowing
expressioncolumns but the fix here is quite simple/easy to follow.