Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc not found #6578

Merged
merged 3 commits into from
Oct 18, 2024
Merged

gcc not found #6578

merged 3 commits into from
Oct 18, 2024

Conversation

ben-schwen
Copy link
Member

Closes #6552

Apparently, we need to set the variable since otherwise it does not find gcc correctly

CI results

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.60%. Comparing base (315ab54) to head (804b2b1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6578      +/-   ##
==========================================
- Coverage   98.62%   98.60%   -0.02%     
==========================================
  Files          79       79              
  Lines       14450    14516      +66     
==========================================
+ Hits        14251    14314      +63     
- Misses        199      202       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelChirico
Copy link
Member

would you mind putting @jangorecki (and yourself?) as CODEOWNERSnfor GLCI?

@ben-schwen ben-schwen merged commit 200d657 into master Oct 18, 2024
9 of 10 checks passed
@ben-schwen ben-schwen deleted the ci_windows_filepaths branch October 18, 2024 16:16
@@ -68,3 +68,6 @@
# docs
/man/openmp-utils.Rd @Anirban166
/Seal_of_Approval.md @tdhock

# GLCI
.gitlab-ci.yml @jangorecki @ben-schwen
Copy link
Member

@jangorecki jangorecki Oct 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this part is unrelated to the issue that this PR is meant to resolve. Also I think any changes to codeowners shouls be discussed before putting other people into it. I would like to assign myself to ci file but knowing I won't have time for really maintaining it in near future, I would not do so.

I see Michael's comment just now which nicely asks about it. Thanks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jangorecki I agree, I probably should have asked before putting your name there. But I don't see it so much as a burden that you have to review everything, but more as documentation (other than git blame) and a chance for us to get your thoughts and feedback (when needed) on changes there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GLCI [test-win-dev][test-win-rel]: Fail to install with 'gcc not found'
3 participants