Fix a scenario which enqueued events are left unprocessed. #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
Floodgate.withValue
owns the recursive lock, events enqueued in parallel might be left unprocessed until another enqueue attempt.This is because
Floodgate.process(_:for:)
assumes that, when the call is reentrant, the lock owner is already running an event drain loop. This holds true whenFloodgate.process(_:for:)
recursively calls itself. But this doesn't hold true whenFloodgate.process(_:for:)
is the indirect caller ofFloodgate.process(_:for:)
.This PR refactored the code path, and makes sure that all
reducerLock
holder fulfills their obligation to drain the event queue after having held the lock.Included a test case that fails on
develop
and2.0.0-beta1
.