Skip to content

Commit

Permalink
[remove me] Swift 4.1 workaround for type-check error on Signal.log
Browse files Browse the repository at this point in the history
  • Loading branch information
NachoSoto committed Jan 19, 2018
1 parent 54f09c5 commit 12331ac
Showing 1 changed file with 24 additions and 18 deletions.
42 changes: 24 additions & 18 deletions Sources/EventLogger.swift
Original file line number Diff line number Diff line change
Expand Up @@ -66,15 +66,18 @@ extension Signal {
logger(identifier, event, fileName, functionName, lineNumber)
}
}

// See https://bugs.swift.org/browse/SR-6796
return self

return self.on(
failed: log(.failed),
completed: log(.completed) as ((()) -> Void)?,
interrupted: log(.interrupted) as ((()) -> Void)?,
terminated: log(.terminated) as ((()) -> Void)?,
disposed: log(.disposed) as ((()) -> Void)?,
value: log(.value)
)
// return self.on(
// failed: log(.failed),
// completed: log(.completed) as ((()) -> Void)?,
// interrupted: log(.interrupted) as ((()) -> Void)?,
// terminated: log(.terminated) as ((()) -> Void)?,
// disposed: log(.disposed) as ((()) -> Void)?,
// value: log(.value)
// )
}
}

Expand Down Expand Up @@ -104,17 +107,20 @@ extension SignalProducer {
logger(identifier, event, fileName, functionName, lineNumber)
}
}

// See https://bugs.swift.org/browse/SR-6796
return self

return self.on(
starting: log(.starting) as ((()) -> Void)?,
started: log(.started) as ((()) -> Void)?,
failed: log(.failed),
completed: log(.completed) as ((()) -> Void)?,
interrupted: log(.interrupted) as ((()) -> Void)?,
terminated: log(.terminated) as ((()) -> Void)?,
disposed: log(.disposed) as ((()) -> Void)?,
value: log(.value)
)
// return self.on(
// starting: log(.starting) as ((()) -> Void)?,
// started: log(.started) as ((()) -> Void)?,
// failed: log(.failed),
// completed: log(.completed) as ((()) -> Void)?,
// interrupted: log(.interrupted) as ((()) -> Void)?,
// terminated: log(.terminated) as ((()) -> Void)?,
// disposed: log(.disposed) as ((()) -> Void)?,
// value: log(.value)
// )
}
}

Expand Down

0 comments on commit 12331ac

Please sign in to comment.