Rename next to value
#8
Conversation
`Observer.sendValue()` becomes `Observer.send(value: )` `Observer.sendFailed()` becomes `Observer.send(error: )` `SignalProducer.startWithNext` becomes `SignalProducer.startWithValues` `SignalProducer.observeNext` becomes `SignalProducer.startWithValues`
|
I feel like we're better off leaving breaking changes like this for a version after the initial one for |
|
This should be easily migrated by API renaming. |
|
What about shortening the rest of |
|
Yeah, the API renaming makes the transition pretty easy IMO. |
|
I would also think it's better to batch up all the possible churn (even if it's slightly more) than spreading it out into multiple changes. |
|
I'll add my vote to the "break everything now rather than later" pile. Seeing how it's already a huge job to port the growing codebase that I have to swift 3, I might as well get all this renaming handled together in one shot. 😛 |
|
Seems like people are mostly on board with making all the breaking changes now. Is everyone 👍🏻 on the change itself? |
| @@ -599,7 +599,7 @@ public final class MutableProperty<Value>: MutablePropertyProtocol { | |||
| /// underlying producer prevents sending recursive events. | |||
| atomic = RecursiveAtomic(initialValue, | |||
| name: "org.reactivecocoa.ReactiveSwift.MutableProperty", | |||
| didSet: observer.sendNext) | |||
| didSet: observer.send(value:)) | |||
|
Ship it then! I'm also on board. |
|
🎉 |
As discussed in ReactiveCocoa/ReactiveCocoa#3013
I rather like this. I don’t think
nextis a particularly great name.valueseems much better to me.Observer.sendValue()becomesObserver.send(value: )Observer.sendFailed()becomesObserver.send(error: )SignalProducer.startWithNextbecomesSignalProducer.startWithValuesSignalProducer.observeNextbecomesSignalProducer.startWithValues