Skip to content

Commit

Permalink
doAfterNext - prevent post-terminal emission (#4903)
Browse files Browse the repository at this point in the history
  • Loading branch information
davidmoten authored and akarnokd committed Dec 3, 2016
1 parent a39fa89 commit d52cce9
Show file tree
Hide file tree
Showing 2 changed files with 47 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ static final class DoAfterSubscriber<T> extends BasicFuseableSubscriber<T, T> {

@Override
public void onNext(T t) {
if (done) {
return;
}
actual.onNext(t);

if (sourceMode == NONE) {
Expand Down
44 changes: 44 additions & 0 deletions src/test/java/io/reactivex/flowable/FlowableDoAfterNextTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
/**
* Copyright 2016 Netflix, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package io.reactivex.flowable;

import static org.junit.Assert.assertEquals;

import java.util.concurrent.atomic.AtomicInteger;

import org.junit.Test;

import io.reactivex.functions.Consumer;

public class FlowableDoAfterNextTest {

@Test
public void testIfFunctionThrowsThatNoMoreEventsAreProcessed() {
final AtomicInteger count = new AtomicInteger();
final RuntimeException e = new RuntimeException();
Burst.items(1, 2).create()
.doAfterNext(new Consumer<Integer>() {
@Override
public void accept(Integer t) throws Exception {
count.incrementAndGet();
throw e;
}})
.test()
.assertError(e)
.assertValue(1);
assertEquals(1, count.get());
}
}

0 comments on commit d52cce9

Please sign in to comment.