OperatorUsing #1100
Merged
OperatorUsing #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #1011 SUCCESS |
| @@ -2590,7 +2590,7 @@ public final Boolean call(T first, T second) { | |||
| * @see <a href="http://msdn.microsoft.com/en-us/library/hh229585.aspx">MSDN: Observable.Using</a> | |||
| */ | |||
| public final static <T, RESOURCE extends Subscription> Observable<T> using(Func0<RESOURCE> resourceFactory, Func1<RESOURCE, Observable<T>> observableFactory) { | |||
There was a problem hiding this comment.
While you are at it, could you rename RESOURCE to Resource. Same for the Operator's class def.
There was a problem hiding this comment.
Belay that, rather have the following signature
<T> Observable<T> using(Func0<? extends Subscription> resourceFactory, Func1<? super Subscription, ? extends Observable<? extends T>> observableFactory)There was a problem hiding this comment.
Your proposal will require a cast in observableFactory if the user wants to use the Resource in observableFactory. So I changed to
public final static <T, Resource extends Subscription> Observable<T> using(
Func0<Resource> resourceFactory,
Func1<Resource, ? extends Observable<? extends T>> observableFactory)
|
RxJava-pull-requests #1021 SUCCESS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operator
UsingIssue #1060