Refactoring language tests and examples layout #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
benjchristensen
commented
Feb 8, 2013
benjchristensen
commented
- removed rxjava-examples as it was not working having all languages in the same project
- started convention of having /src/examples/ in language-adaptors with first implementation being rxjava-groovy and rxjava-clojure (though the clojure one isn't compiling correctly yet)
- moved language unit tests to actual language rather than via Java to language parsers
- testing all Groovy functionality doesn't belong as an inner class - it was awkard to load Groovy scripts via Java (leftover from previous codebase where Groovy wasn't part of build, only a runtime library) - establish convention for each language to have a suite of tests in /src/test
Examples have been moved into /src/examples folders of each language-adaptor subproject.
- examples are in /src/examples/clojure - placeholder for unit tests in /src/tests
- examples are in /src/examples/groovy
benjchristensen
added a commit
that referenced
this pull request
Feb 8, 2013
Refactoring language tests and examples layout
|
@daveray I couldn't quite figure out the clojuresque plugin to get /src/examples building and could probably benefit from your guidance on the right way to get unit tests working in https://github.com/Netflix/RxJava/blob/master/language-adaptors/rxjava-clojure/src/test/clojure/rx/lang/clojure/observable_tests.clj I want them to work similar to https://github.com/Netflix/RxJava/blob/master/language-adaptors/rxjava-groovy/src/test/groovy/rx/lang/groovy/ObservableTests.groovy |
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
…and-examples Refactoring language tests and examples layout
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
Additional tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.