TakeWhile: don't unsubscribe downstream. #2648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param op the other subscriber | ||
| * @param shareSubscriptions should the subscription list in op shared with this instance? | ||
| */ | ||
| protected Subscriber(Subscriber<?> op, boolean shareSubscriptions) { |
There was a problem hiding this comment.
Are there other places this constructor should be used where we're doing it manually today?
There was a problem hiding this comment.
Thought so ... thanks for the confirmation.
There was a problem hiding this comment.
I just merged this ... but I'm always hesitant when changing something as core as Subscriber. Are we ready to support this new method forever. Is it the right signature for all the use cases?
I think it's right, but I've regretted public API decisions before :-)
/cc @zsxwing @abersnaze for more eyes and thought on this.
benjchristensen
added a commit
that referenced
this pull request
Feb 11, 2015
TakeWhile: don't unsubscribe downstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2647 issue with TakeWhile.