Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.x: add AsyncCompletableSubscriber that exposes unsubscribe() #4020

Merged
merged 1 commit into from
Jun 21, 2016
Merged

1.x: add AsyncCompletableSubscriber that exposes unsubscribe() #4020

merged 1 commit into from
Jun 21, 2016

Conversation

akarnokd
Copy link
Member

This PR adds a default, abstract base class with unsubscription support for Completable's CompletableSubscriber.

Pros: direct, slim class

Cons: people probably used subscriber(Action0) or subscribe(Subscriber) so far.

Related: #4017

@stevegury
Copy link
Member

👍

@akarnokd akarnokd merged commit 03bc7a2 into ReactiveX:1.x Jun 21, 2016
@akarnokd akarnokd deleted the AsyncCompletableSubscriber branch June 21, 2016 21:22
@akarnokd akarnokd mentioned this pull request Jun 21, 2016
Closed
@akarnokd akarnokd mentioned this pull request Jun 30, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akarnokd @stevegury