Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observable.timeout/Flowable.timeout should unsubscribe from underlying subscription on dispose #4536

Merged
merged 1 commit into from
Sep 12, 2016
Merged

Conversation

nsk-mironov
Copy link
Contributor

@nsk-mironov nsk-mironov commented Sep 12, 2016

No description provided.

@nsk-mironov nsk-mironov changed the title Observable/Flowable should unsubscribe from underlying subscription on dispose Observable.timeout/Flowable.timeout should unsubscribe from underlying subscription on dispose Sep 12, 2016
@codecov-io
Copy link

Current coverage is 78.72% (diff: 100%)

Merging #4536 into 2.x will increase coverage by <.01%

@@                2.x      #4536   diff @@
==========================================
  Files           527        527          
  Lines         35142      35142          
  Methods           0          0          
  Messages          0          0          
  Branches       5457       5457          
==========================================
+ Hits          27663      27665     +2   
  Misses         5509       5509          
+ Partials       1970       1968     -2   

Powered by Codecov. Last update 56d5586...2dc0132

@akarnokd akarnokd added the Bug label Sep 12, 2016
@akarnokd akarnokd added this to the 2.0 RC 3 milestone Sep 12, 2016
@akarnokd
Copy link
Member

Thanks!

@akarnokd akarnokd merged commit 1ebd979 into ReactiveX:2.x Sep 12, 2016
@akarnokd akarnokd mentioned this pull request Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants