2.x: Add singleOrError, firstOrError, lastOrError & elementAtOrError to Observable and Flowable #4589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akarnokd
approved these changes
Sep 23, 2016
| @@ -104,7 +105,12 @@ public void onComplete() { | |||
| s = SubscriptionHelper.CANCELLED; | |||
| if (index <= count && !done) { | |||
| done = true; | |||
| actual.onSuccess(defaultValue); | |||
|
|
|||
| if (defaultValue != null) { | |||
There was a problem hiding this comment.
T v = defaultValue;
if (v != null) {
actual.onSuccess(v);
} else {| @@ -96,7 +99,11 @@ public void onError(Throwable t) { | |||
| public void onComplete() { | |||
| if (index <= count && !done) { | |||
| done = true; | |||
| actual.onSuccess(defaultValue); | |||
| if (defaultValue != null) { | |||
|
There are javadoc mistakes btw. |
|
Yup I saw them and I'll fix them up. I didn't execute that test locally. (running all tests take forever on my local machine) |
Current coverage is 78.10% (diff: 100%)@@ 2.x #4589 diff @@
==========================================
Files 552 552
Lines 36247 36272 +25
Methods 0 0
Messages 0 0
Branches 5594 5601 +7
==========================================
+ Hits 28293 28332 +39
+ Misses 5944 5923 -21
- Partials 2010 2017 +7
|
|
Oh, this broke because of the error fixes. /cc @JakeWharton and @abersnaze on naming/functionality. |
…to Observable and Flowable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4588