2.x: assertNever(T value) / assertNever(Predicate<T> valuePredicate) #4994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 95.55% (diff: 86.66%)@@ 2.x #4994 diff @@
==========================================
Files 592 592
Lines 37969 37989 +20
Methods 0 0
Messages 0 0
Branches 5752 5772 +20
==========================================
+ Hits 36273 36302 +29
+ Misses 741 727 -14
- Partials 955 960 +5
|
vanniktech
reviewed
Jan 14, 2017
| @@ -84,6 +84,58 @@ public void testAssertNotMatchValue() { | |||
| } | |||
|
|
|||
| @Test | |||
| public void assertNeverAtNotMatchingValue() { | |||
There was a problem hiding this comment.
those tests should also be in TestObserverTest
There was a problem hiding this comment.
You have to test when the methods throw becaue the forbidden item is there.
There was a problem hiding this comment.
@akarnokd look at assertNeverAtMatchingValue() and assertNeverAtMatchingPredicate(). Is that what you mean?
Added the tests to TestObserverTest too.
akarnokd
requested changes
Jan 14, 2017
| * @return this; | ||
| */ | ||
| @SuppressWarnings("unchecked") | ||
| public final U assertNever(T value) { |
| * @return this | ||
| */ | ||
| @SuppressWarnings("unchecked") | ||
| public final U assertNever(Predicate<T> valuePredicate) { |
| @@ -84,6 +84,58 @@ public void testAssertNotMatchValue() { | |||
| } | |||
|
|
|||
| @Test | |||
| public void assertNeverAtNotMatchingValue() { | |||
There was a problem hiding this comment.
You have to test when the methods throw becaue the forbidden item is there.
akarnokd
approved these changes
Jan 16, 2017
akarnokd
requested changes
Jan 17, 2017
| */ | ||
| @Experimental | ||
| @SuppressWarnings("unchecked") | ||
| public final U assertNever(Predicate<T> valuePredicate) { |
| * @param valuePredicate the predicate that receives the onNext value | ||
| * and should return true for the expected value. | ||
| * @return this | ||
| */ |
| * | ||
| * @param value the value to expect not being received | ||
| * @return this; | ||
| */ |
akarnokd
approved these changes
Jan 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds to any class extending
BaseConsumerTestthe ability to assert that a given value was not emitted by the observable it was subscribed to, either withassertNever(T value)orassertNever(Predicate<T> valuePredicate)