Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: improve the parallel() mode test coverage, improve its code #5006

Merged
merged 1 commit into from
Jan 20, 2017

Conversation

akarnokd
Copy link
Member

This PR adds additional unit tests for the parallel() operators, plus:

  • adds conditional fusion to runOn, filter and map operators
  • exposes the FlowableFlatMap's internal Subscriber to be reused with ParallelFlowable.flatMap
  • uses the FlowableConcatMap's internal Subscriber to be reused with ParallelFlowable.concatMap
  • fix generics with collect and reduce
  • change queue overflow errors to MissingBackpressureException
  • make sure join-like operators don't emit the same upstream Throwable to the RxJavaPlugins.onError handler if all rails have the same error reference

@codecov-io
Copy link

Current coverage is 95.60% (diff: 95.91%)

Merging #5006 into 2.x will increase coverage by 0.80%

@@                2.x      #5006   diff @@
==========================================
  Files           609        609          
  Lines         39228      39363   +135   
  Methods           0          0          
  Messages          0          0          
  Branches       5993       6025    +32   
==========================================
+ Hits          37188      37632   +444   
+ Misses          991        749   -242   
+ Partials       1049        982    -67   

Powered by Codecov. Last update 6c88036...9da3126

@akarnokd akarnokd merged commit dadb49a into ReactiveX:2.x Jan 20, 2017
@akarnokd akarnokd deleted the ParallelTestEnhancement branch January 20, 2017 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants