Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: disable codecov-checks on PRs #5057

Merged
merged 2 commits into from
Feb 3, 2017

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Feb 3, 2017

Codecov.io seems to be messing around quite a bit lately. A day after the integration, new checks appeared at every PR that fail because of small irrelevant fluctuations in the coverage itself and they fail the whole PR even though the tests pass.

This PR seeks to disable these checks.

@codecov
Copy link

codecov bot commented Feb 3, 2017

Codecov Report

Merging #5057 into 2.x will increase coverage by 0.04%.

@@             Coverage Diff              @@
##                2.x    #5057      +/-   ##
============================================
+ Coverage     95.57%   95.62%   +0.04%     
+ Complexity     5542     5539       -3     
============================================
  Files           612      612              
  Lines         39576    39576              
  Branches       5553     5553              
============================================
+ Hits          37824    37843      +19     
+ Misses          764      750      -14     
+ Partials        988      983       -5
Impacted Files Coverage Δ Complexity Δ
...rnal/operators/completable/CompletableTimeout.java 92.3% <ø> (-5.13%) 2% <ø> (ø)
...rnal/subscriptions/DeferredScalarSubscription.java 93.84% <ø> (-4.62%) 27% <ø> (-1%)
.../operators/observable/ObservableFlatMapSingle.java 92.53% <ø> (-3.74%) 2% <ø> (ø)
...vex/internal/operators/flowable/FlowableTimer.java 92.85% <ø> (-3.58%) 2% <ø> (ø)
...ernal/operators/flowable/FlowableFromIterable.java 90.9% <ø> (-3.21%) 5% <ø> (ø)
...ava/io/reactivex/internal/util/HalfSerializer.java 97.5% <ø> (-2.5%) 22% <ø> (-1%)
...ternal/operators/completable/CompletableUsing.java 97.61% <ø> (-2.39%) 4% <ø> (ø)
.../main/java/io/reactivex/subjects/AsyncSubject.java 97.41% <ø> (-1.73%) 55% <ø> (-1%)
...n/java/io/reactivex/processors/AsyncProcessor.java 97.45% <ø> (-1.7%) 55% <ø> (-1%)
...al/operators/observable/ObservableSampleTimed.java 96.66% <ø> (-1.67%) 3% <ø> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5d3b0e...966cf2a. Read the comment docs.

@akarnokd akarnokd merged commit acc5da6 into ReactiveX:2.x Feb 3, 2017
@akarnokd akarnokd deleted the CodecovChecksDisable branch February 3, 2017 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant