Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: add Single.unsubscribeOn() #5302

Merged
merged 2 commits into from
Apr 20, 2017
Merged

Conversation

akarnokd
Copy link
Member

This PR adds the Single.unsubscribeOn() operator.

Related: #5300.

@akarnokd akarnokd added this to the 2.1 milestone Apr 20, 2017
*/
@CheckReturnValue
@SchedulerSupport(SchedulerSupport.NONE)
@SuppressWarnings("unchecked")
@Experimental
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this landed on the wrong method

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed.

@codecov
Copy link

codecov bot commented Apr 20, 2017

Codecov Report

Merging #5302 into 2.x will decrease coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5302      +/-   ##
============================================
- Coverage     96.17%   96.09%   -0.08%     
  Complexity     5756     5756              
============================================
  Files           628      629       +1     
  Lines         41085    41112      +27     
  Branches       5703     5705       +2     
============================================
- Hits          39514    39508       -6     
- Misses          613      629      +16     
- Partials        958      975      +17
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Single.java 99.33% <100%> (ø) 132 <1> (+1) ⬆️
...internal/operators/single/SingleUnsubscribeOn.java 100% <100%> (ø) 2 <2> (?)
...rnal/subscriptions/ArrayCompositeSubscription.java 93.33% <0%> (-6.67%) 17% <0%> (-1%)
...internal/operators/completable/CompletableAmb.java 94.91% <0%> (-5.09%) 10% <0%> (-1%)
...erators/completable/CompletableConcatIterable.java 95.91% <0%> (-4.09%) 2% <0%> (ø)
...ernal/operators/maybe/MaybeTakeUntilPublisher.java 96% <0%> (-4%) 2% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 93.28% <0%> (-2.99%) 2% <0%> (ø)
...activex/internal/operators/single/SingleCache.java 97.05% <0%> (-2.95%) 23% <0%> (-1%)
...ex/internal/operators/maybe/MaybeTimeoutMaybe.java 95.58% <0%> (-2.95%) 2% <0%> (ø)
...nternal/operators/parallel/ParallelSortedJoin.java 92.75% <0%> (-2.9%) 2% <0%> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db62772...506d8ee. Read the comment docs.

@akarnokd akarnokd merged commit 6c58557 into ReactiveX:2.x Apr 20, 2017
@akarnokd akarnokd deleted the SingleUnsubscribeOn branch April 20, 2017 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants