Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Try fixing Travis CI lack of java #5531

Merged
merged 3 commits into from
Aug 1, 2017
Merged

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Aug 1, 2017

Travis CI has replaced the previous Precise image with the Trusty image as part of an ongoing rollout. Unfortunately, the Trusty image fails for oraclejdk7 because probably it is no longer supported (although I couldn't find anything about it).

This PR tries to identify what's available by trying a matrix of build setups.

@akarnokd
Copy link
Member Author

akarnokd commented Aug 1, 2017

Looks like Trusty only supports Java 8 builds:

image

There is also a test failure of MaybeFromRunnableTest.noErrorLoss due to being sensitive to delays.

Forcing dist: precise works.

@JakeWharton
Copy link
Member

JakeWharton commented Aug 1, 2017 via email

@codecov
Copy link

codecov bot commented Aug 1, 2017

Codecov Report

Merging #5531 into 2.x will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5531      +/-   ##
============================================
+ Coverage     96.14%   96.18%   +0.03%     
- Complexity     5806     5822      +16     
============================================
  Files           631      631              
  Lines         41285    41405     +120     
  Branches       5732     5737       +5     
============================================
+ Hits          39693    39824     +131     
- Misses          629      630       +1     
+ Partials        963      951      -12
Impacted Files Coverage Δ Complexity Δ
...l/operators/observable/ObservableFlatMapMaybe.java 85.62% <0%> (-9.81%) 2% <0%> (ø)
...in/java/io/reactivex/subjects/BehaviorSubject.java 86.97% <0%> (-5.73%) 57% <0%> (ø)
...tivex/internal/schedulers/InstantPeriodicTask.java 61.11% <0%> (-5.56%) 7% <0%> (-2%)
.../operators/observable/ObservableFlatMapSingle.java 91.79% <0%> (-4.48%) 2% <0%> (ø)
...erators/completable/CompletableConcatIterable.java 95.91% <0%> (-4.09%) 2% <0%> (ø)
...nternal/operators/parallel/ParallelReduceFull.java 91.17% <0%> (-3.93%) 2% <0%> (ø)
...nternal/operators/observable/ObservableCreate.java 92.3% <0%> (-3.42%) 2% <0%> (ø)
...rnal/operators/flowable/FlowableFlatMapSingle.java 93.47% <0%> (-3.27%) 2% <0%> (ø)
...rnal/operators/observable/ObservableObserveOn.java 97.95% <0%> (-2.05%) 3% <0%> (ø)
...a/io/reactivex/internal/queue/MpscLinkedQueue.java 98.03% <0%> (-1.97%) 17% <0%> (-1%)
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac06c24...8752260. Read the comment docs.

@akarnokd
Copy link
Member Author

akarnokd commented Aug 1, 2017

It is an option; there was already a switch to oraclejdk7 back when the JDK 6 support dropped.

Should we switch to oraclejdk8 and run on trusty?

@JakeWharton
Copy link
Member

JakeWharton commented Aug 1, 2017 via email

@artem-zinnatullin
Copy link
Contributor

I'd propose switching build to Docker where we can better control what environment is actually in the build and test against multiple versions of JDK properly (if needed).

Also with Docker we'll be able to reproduce CI builds very precisely (except hardware limits).

@akarnokd
Copy link
Member Author

akarnokd commented Aug 1, 2017

That's too risky and may not work due to the encrypted credentials we have here for maven upload.

@artem-zinnatullin
Copy link
Contributor

I don't see problems with that, both files and environment variables can be easily passed to Docker container so that should solve maven upload.

And I actually think that keeping environment under Travis control (they update things) is more dangerous.

@akarnokd akarnokd merged commit e9a9af3 into ReactiveX:2.x Aug 1, 2017
@akarnokd akarnokd deleted the Trusty branch August 1, 2017 21:29
NickFirmani pushed a commit to NickFirmani/RxJava that referenced this pull request Aug 1, 2017
* 2.x: Try fixing Travis CI lack of java

* Force dist: precise

* Oracle JDK 8 is then
akarnokd pushed a commit that referenced this pull request Aug 2, 2017
* Add assertValueAt(int, value) to TestObserver

* Fix test to call correct method

* David's comments

* Artem's comments

* 2.x: Try fixing Travis CI lack of java (#5531)

* 2.x: Try fixing Travis CI lack of java

* Force dist: precise

* Oracle JDK 8 is then
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants